Issue SetDrawColorBuffers before clearing buffers in GLES, use clear_buffer_f32_slice instead of clear #5666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary for glClearBuffer calls to work correctly on some machines (e.g. AMD Renoir graphics running on Linux). Without this, glClearBuffer calls are ignored.
…ings This fixes the following WebGL warning: "WebGL warning: drawBuffers: `buffers[i]` must be NONE or COLOR_ATTACHMENTi." When using native OpenGL, it is acceptable to call glDrawBuffers with an array of buffers where i != COLOR_ATTACHMENTi. In WebGL, this is not allowed.
cwfitzgerald
approved these changes
May 9, 2024
There was a problem hiding this comment.
Code looks good! @Zoxc if you can test on sandy bridge, but I lets not block on that
EriKWDev
pushed a commit
to bitwise-git/wgpu
that referenced
this pull request
May 14, 2024
…buffer_f32_slice instead of clear (gfx-rs#5666) * Issue SetDrawColorBuffers commands before issuing ClearColor This is necessary for glClearBuffer calls to work correctly on some machines (e.g. AMD Renoir graphics running on Linux). Without this, glClearBuffer calls are ignored. * Use clear_buffer_f32_slice instead of gl.clear to suppress WebGL warnings This fixes the following WebGL warning: "WebGL warning: drawBuffers: `buffers[i]` must be NONE or COLOR_ATTACHMENTi." When using native OpenGL, it is acceptable to call glDrawBuffers with an array of buffers where i != COLOR_ATTACHMENTi. In WebGL, this is not allowed. * Run cargo fmt * Add changes for PR gfx-rsGH-5666 to the CHANGELOG
jimblandy
pushed a commit
to jimblandy/wgpu
that referenced
this pull request
May 23, 2024
…buffer_f32_slice instead of clear (gfx-rs#5666) * Issue SetDrawColorBuffers commands before issuing ClearColor This is necessary for glClearBuffer calls to work correctly on some machines (e.g. AMD Renoir graphics running on Linux). Without this, glClearBuffer calls are ignored. * Use clear_buffer_f32_slice instead of gl.clear to suppress WebGL warnings This fixes the following WebGL warning: "WebGL warning: drawBuffers: `buffers[i]` must be NONE or COLOR_ATTACHMENTi." When using native OpenGL, it is acceptable to call glDrawBuffers with an array of buffers where i != COLOR_ATTACHMENTi. In WebGL, this is not allowed. * Run cargo fmt * Add changes for PR gfx-rsGH-5666 to the CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, CommandEncoder issues
SetDrawColorBuffersafter issuingClearColorF,ClearColorUandClearColorI. On AMD Renoir graphics on Linux, this results inglClearBuffercalls sometimes being ignored. I can see theglClearBuffercalls in RenderDoc, but the output texture is not cleared. I suspect that this may also be the cause of some of the crashes on other machines (e.g. Sandy Bridge on Windows).It seems that the correct way to use
glClearBufferis to callglDrawBuffersbefore callingglClearBuffer.Additionally, I've replaced the
glClearcall withglClearBufferF(viaglow::clear_buffer_f32_slice), becauseglDrawBuffersdoes not like it when you passCOLOR_ATTACHMENTias thej-th buffer unlessi==j. When rendering using a WebGL backend, this results in warnings:On native OpenGL, this doesn't seem to be an issue, but the spec for OpenGL ES 3.2 also demands this:
(See page 398, OpenGL ES 3.2)
Testing
Theoretically, issuing
SetDrawColorBuffers(0)before beginning a render pass (maybe with a non-default frame-buffer?) and attempting to clear the color buffers will result in the clear commands being ignored on some machines. Admittedly, I've only tested this in a larger application, so I don't have a self-contained test for this.The changes regarding clearing float buffers can be verified by attempting to clear buffers as part of a render pass involving multiple color attachments in WebGL (both Firefox and Chrome produce similar warnings).
It would be great if someone could verify that this fixes their issues on Sandy Bridge on Windows, because I've removed (a part of) the workaround in hopes that the crashes were caused by this bug(or quirk).
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.