Fix QuerySet ownership of ComputePass #5671
Draft
+1,764
−649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rectly on recording TODO: * bind groups don't work because the Binder gets an id only * wgpu level error handling is missing
…eeds to lock bind_group storage
… DynComputePass on wgpu side
…hod of compute/render pass instead of encoder
…removing compile time dependency to it
…mestamp, timestamp_writes (on desc) and pipeline statistic queries
This was referenced May 5, 2024
Wumpf
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Connections
ComputePassto its parent command encoder #5620RenderPassmake it difficult to use. #1453Part of a series towards lifetime removal on compute passes:
wgpu::ComputePass) #5432wgpu::ComputePassmethods #5570ComputePassto its parent command encoder #5620last piece of solving lifetime constraints for
ComputePassDescription
Technically this PR is a bugfix: Previously, when destroying a
QuerySetthat is used in any way (eitherwrite_timestamp,ComputePassTimestampWritesorbegin_pipeline_statistics_query) before executing the pass, we would crash.This solves this as in the PRs before by taking ownership of the query the moment it is provided.
Testing
Adds two new tests that test for gracefully handling destroyed query set before the compute pass is executed.
Both tests failed before the fix.
Checklist
cargo fmt.cargo clippy. If applicable, add:--target wasm32-unknown-unknown--target wasm32-unknown-emscriptencargo xtask testto run tests.CHANGELOG.md. See simple instructions inside file.