Allow additionalRulesDirs to be specified in config #244
Conversation
Pull Request Test Coverage Report for Build 585
💛 - Coveralls |
These lines were already uncovered, and have just moved within the file. Not sure why they're showing as having lost coverage as they weren't covered before. |
|
Pinging @vsiakka, Any chance of a review of this code? Thanks |
|
Hey @andrewnicols , thank for the change and sorry for the huge delay for my review. Having said that, I think treading "additionalRulesDirs" as another rule configuration is ideal in my opinion. I don't find it intuitive from the perspective of someone writing a config file or from the person working on the gherkin-lint code. I think the correct approach for this is to change the layout of the This will mean that the api of the project will change so it will be a major version release which I'm fine with doing. |
andrewnicols
force-pushed
the
additionalRulesConfig
branch
from
ea79fb7
to
61bab63
Compare
|
Hi @vsiakka , Apologies for the delay on this one. I was in a car accident around this time, then had a child, and life happened. I've made the following changes:
|
|
I'm guessing this probably needs to be converted to using GHA rather than Travis. Let me know if there's anything I can do to help. Cheers |
This change will allow for future changes to the gherkinlint configuration file for configuration of non-rule based features.
This commit moves the configuration for the rules from being in the root
of the configuration directive into a "rules" object, for example:
Before:
```json
{
"rule": "on"
}
```
After:
```json
{
"rules": {
"rule": "on"
}
}
```
This allow for additional non-rule configuration to be provided.
andrewnicols
force-pushed
the
additionalRulesConfig
branch
from
61bab63
to
ee2c76a
Compare
|
Blocked by #248 |
|
Updated following feedback :) |
Allow a list of additionalRulesDirs to be specified in the gherkin-lintrc configuration.
If a list of paths is provided as an argument then this takes precedence over the value in configuration.
Any additionalRulesDirs specified in configuration is calculated relative to the gherkin-lintrc.