replace package 'gherkin' with '@cucumber/gherkin' #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonhamm
force-pushed
the
update-deprecated-cucumber-and-gherkin-packages
branch
2 times, most recently
from
ceede4a
to
3184198
Compare
Rationale: npm WARN deprecated cucumber-messages@8.0.0: This package is now published under @cucumber/messages npm WARN deprecated gherkin@9.0.0: This package is now published under @cucumber/gherkin The rule no-partially-commented-tag-lines is deleted as the new parser will remove the partial comments from taglines and hence they pose no problem and it is not possible to see these comments in the parsed output Delete test that tests that multiple errors can be reported on same feature file, but it turns out that the new parser does not report errors that make it possible to distinguish this case as previous. The test is not required because it is not required that multiple errors are reported, we only need to ensure that all errors are eventually reported, and other tests will do this.
jonhamm
force-pushed
the
update-deprecated-cucumber-and-gherkin-packages
branch
from
3184198
to
9dc65e3
Compare
|
Hi @jonhamm , Regarding the removal of the no-partially-commented-tag-lines rule, can you provide a source for this? My concern here is that whilst cucumber/cucumber-js may have updated their parser to support this, not all parsers will have done so. People use this tooling to lint cucumber and gherkin files which are tested in other languages too. |
|
It looks like bumping to the latest version also breaks other changes because the parser has chnaged fairly significantly in the past few years. This may need a bit of work to handle some of the new warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale:
npm WARN deprecated cucumber-messages@8.0.0: This package is now published under @cucumber/messages npm WARN deprecated gherkin@9.0.0: This package is now published under @cucumber/gherkin
Derived changes:
The rule no-partially-commented-tag-lines is deleted as the new parser will remove the partial comments from taglines and hence they pose no problem and it is not possible to see these comments in the parsed output
Delete test that tests that multiple errors can be reported on same feature file, but it turns out that the new parser does not report errors that make it possible to distinguish this case as previous. The test is not required because it is not required that multiple errors are reported, we only need to ensure that all errors are eventually reported, and other tests will do this.