Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Unknown mode #1692

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Added Unknown mode #1692

wants to merge 9 commits into from

Conversation

agusalex
Copy link

@agusalex agusalex commented Feb 12, 2023

On the Asset Allocation page when some assets are not recognized by sector or country, it cant get pretty hard to understand the distribution of things. It is particularly annoying with cash, since it is common to have some amount of it, and this would cause the countries to chart and the sector chart to show UNKNOWN as a type.

This is what got changed to remediate this issue:

  • Added ETF support to Yahoo provider so that ETFs get properly populated on the sector and country chart
  • Added Unkown Mode to users decide if they want to view an accurate chart of sector and country or a cleaner one that shows the data that's relevant, this way we don't sacrifice precision or ease of use.
  • Set Unknown mode to default ON ( same behavior as before ) and it is the user's choice to disable it. It's my opinion the platform looks better with it off but I didn't want to disrupt previous behavior.

@agusalex agusalex changed the title Added Unkown mode and fixed USD being added to sectors as Unknown Added Unkown mode Feb 13, 2023
@agusalex agusalex changed the title Added Unkown mode Added Unknown mode Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant