Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix - issue with total value of activites not showing #2364

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

FraneCaleta
Copy link
Contributor

For more informations it's best to check issue #2363.

It's a small fix which prevents "null" from showing to the user.
So basically, if we have one of these activities: Dividend, Fee, Interest, Liability or Sell we will just ignore them and continue with our loop which counts the total value of types Buy and Item.

image

In this picture we can see that totalValue is now being properly displayed and counted.
You can find a picture with bug in the issue #2363.

@dtslvr
Copy link
Member

dtslvr commented Sep 21, 2023

The problem with this implementation I see is the following:

BUY  1 Alphabet $1000
SELL 1 Alphabet $1200
-----------------------
                $1000 <-- ???

@FraneCaleta
Copy link
Contributor Author

The problem with this implementation I see is the following:

BUY  1 Alphabet $1000
SELL 1 Alphabet $1200
-----------------------
                $1000 <-- ???

I guess the main question is how exactly do we want this to function, the implementation part seems pretty straight forward :)

In the example you showed, do you think the best behaviour would be to display 2200? Or -200?

Should we perhaps add all Item, Dividend and Buy types and then substract them with Liabilities, Fees, Interests and Sell types?

I think it's better to discuss and choose one approach rather than displaying nothing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants