Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document logging architecture #2170

Merged
merged 24 commits into from Mar 25, 2024
Merged

Conversation

QuentinBisson
Copy link
Contributor

What this PR does / why we need it

Closes https://github.com/giantswarm/giantswarm/issues/29776#issue-2122988280

This documentation explains what our logging architecture is

Things to check/remember before submitting

  • If you made content changes

    • Run make dev to render and proofread content changes locally.
    • Bump last_review_date in the front matter header if you reviewed the entire page.

@QuentinBisson QuentinBisson self-assigned this Mar 21, 2024
Copy link
Contributor

@QuantumEnigmaa QuantumEnigmaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just personal suggestions, don't feel obliged to apply those :)

QuentinBisson and others added 9 commits March 21, 2024 15:29
…itecture/index.md

Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
…itecture/index.md

Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
…itecture/index.md

Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
…itecture/index.md

Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
…itecture/index.md

Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
…itecture/index.md

Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
…itecture/index.md

Co-authored-by: Zirko <64951262+QuantumEnigmaa@users.noreply.github.com>
@QuentinBisson QuentinBisson marked this pull request as ready for review March 21, 2024 15:13
@QuentinBisson QuentinBisson requested a review from a team as a code owner March 21, 2024 15:13
QuentinBisson and others added 10 commits March 21, 2024 22:08
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
…itecture/index.md

Co-authored-by: Zach Stone <zach@giantswarm.io>
@QuentinBisson
Copy link
Contributor Author

Thanks for the review @stone-z :) I always love a native speaker's nitpicking :)

Copy link
Contributor

@lyind lyind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome docs 👍

Minor suggestions


Kubernetes clusters produces a vast amount of logs, whether they come from machines or containers.

The loggings agents that we have deployed on both management and workload clusters currently send the following logs to Loki:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The loggings agents that we have deployed on both management and workload clusters currently send the following logs to Loki:
The logging agents that we have deployed on both management and workload clusters currently send the following logs to Loki:

…itecture/index.md

Co-authored-by: Jonas Zeiger <jonas@giantswarm.io>
@QuentinBisson QuentinBisson requested a review from a team March 21, 2024 21:31
@marians
Copy link
Member

marians commented Mar 22, 2024

Loki should be spelled Loki (uppercase L) everywhere.

@QuentinBisson
Copy link
Contributor Author

Thanks @marians, it's fixed

@QuentinBisson QuentinBisson added this pull request to the merge queue Mar 25, 2024
Merged via the queue into main with commit 36d5d6e Mar 25, 2024
8 checks passed
@QuentinBisson QuentinBisson deleted the document-logging-architecture branch March 25, 2024 08:44
Comment on lines +23 to +25
Logging is an important pillar of observability and it is thus only natural that Giant Swarm provides and manages a logging solution for operational purposes.

This document gives an overview of how logging is managed by Giant Swarm, including which logs are stored, which tools we use to ship and store them, as well as why we chose those tools in the first place.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't tell the customer much why it's helpful for them. What are operational purposes? Does that mean they or only we can make use of it? I'd recommend shortening this intro, include customer-relevant points and only describe what's important to them. I assume that customers can make use of the MC Grafana instance (see existing article How to access Grafana which btw has a misspelled title it's/its) and therefore we should strongly hint here why the architecture is important for customers (e.g. long-term storage, persistence, easy access via Grafana UI, ...) but not go into extensive detail or opinions ("the full Elastic stack is obviously out of the question").

@pipo02mix I'm very unclear what was discussed around vintage docs. Shouldn't we start from scratch rather than editing existing docs? If so, we'd better revamp the whole thing and go through the "battle card" preparation before writing full articles. Since I'm unclear about this, I'd like to have it clarified first and will stop my review here for now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may be biased but operational purposes is quite straightforward to me. We need it to operate our platform and those 2 sentences have the same meanings.
I am not talking about the customer use yet here, only that they can access it via grafana.

Now, maybe the why we use Loki instead of Grafana could be somewhere else, I wrote this under the after some discussions with @carillan81 and @pipo02mix .

The goal of this doc is to show what we have and show our expertise but maybe the battlecard approach was missed.

Regarding the structure, I put this under vintage for now because of the full revamp being done and I have no issues moving it and refining the content later on with said battlecard, but in the mean time, I think this type of doc is useful and needs to be there. I could be wrong also but it's still better than having nothing at the moment at least

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed – I was writing my direct thoughts to challenge and make everyone think if everything still fits what we have here. We should check from scratch which pieces we put where, and if we can make it all shorter to increase chances of reading these articles. For example, does it fit into introductional, instructional or rather advanced parts of our docs, etc.?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always happy with any feedback :)

@marians
Copy link
Member

marians commented Mar 25, 2024

I didn't expect new content to be added to the /vintage folder. Slightly confused now.

@QuentinBisson
Copy link
Contributor Author

QuentinBisson commented Mar 25, 2024

@marians I added it under vintage because to me, the new structure is not complete. There are no entries there yet and we needed that documentation finished to close our logging epic

@pipo02mix
Copy link
Contributor

I am working to have a second-level hierarchy done to start moving/adapting content. PRs are up so I would be happy to see more reviews 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants