Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lower resource requests and limits, make them configurable #238

Merged
merged 1 commit into from Mar 14, 2024
Merged

Lower resource requests and limits, make them configurable #238

merged 1 commit into from Mar 14, 2024

Conversation

marians
Copy link
Member

@marians marians commented Mar 13, 2024

Towards

What does this PR do?

This reduces the requests and also makes requests and limits configurable via user values.

Utilization before this change:

image

@marians marians self-assigned this Mar 13, 2024
@marians marians requested a review from a team as a code owner March 13, 2024 16:04
@marians marians requested a review from gusevda March 13, 2024 16:10
lyind
lyind approved these changes Mar 13, 2024
View reviewed changes
Copy link
Contributor

@lyind lyind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

However, 60M => OOMKill for a NodeJS app seems quite harsh. (?)

@marians
Copy link
Member Author

marians commented Mar 14, 2024

As with intranet, let's observe and adapt

@marians marians merged commit 75ed529 into main Mar 14, 2024
7 checks passed
@marians marians deleted the resources branch March 14, 2024 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lyind lyind lyind approved these changes

@gusevda gusevda Awaiting requested review from gusevda

Assignees

@marians marians

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@marians @lyind