This repository has been archived by the owner on Dec 11, 2023. It is now read-only.
Release v7.2.0 #653
Merged
Release v7.2.0 #653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QuentinBisson
force-pushed
the
master#release#v7.2.0
branch
11 times, most recently
from
c92f21a
to
ee5959f
Compare
Comment on lines
+379
to
+393
| var cacheOptions = cache.Options{ | ||
| SyncPeriod: to.DurationP(c.resyncPeriod), | ||
| } | ||
| if c.namespace != "" { | ||
| cacheOptions.DefaultNamespaces = map[string]cache.Config{ | ||
| c.namespace: cache.Config{}, | ||
| } | ||
| } | ||
| o := manager.Options{ | ||
| // MetricsBindAddress is set to 0 in order to disable it. We do this | ||
| // ourselves. | ||
| MetricsBindAddress: DisableMetricsServing, | ||
| Namespace: c.namespace, | ||
| SyncPeriod: to.DurationP(c.resyncPeriod), | ||
| Cache: cacheOptions, | ||
| Metrics: server.Options{ | ||
| // MetricsBindAddress is set to 0 in order to disable it. We do this | ||
| // ourselves. | ||
| BindAddress: DisableMetricsServing, | ||
| }, |
There was a problem hiding this comment.
What is this for? It should be mentioned in CHANGELOG, and could also be moved to a different PR unless its fixing some issue introduced by dependency upgrade.
There was a problem hiding this comment.
Yes it's only fixing issues with breaking changes in controller-runtime upgrade. Behavior is the same or at least should bé from what I read upstream
There was a problem hiding this comment.
There was a problem hiding this comment.
@TheoBrigitte I'll merge when you approve :)
QuentinBisson
force-pushed
the
master#release#v7.2.0
branch
2 times, most recently
from
edf9f61
to
2498e71
Compare
| @@ -397,7 +408,6 @@ func (c *Controller) bootWithError(ctx context.Context) error { | |||
| For(c.newRuntimeObjectFunc()). | |||
| WithOptions(controller.Options{ | |||
| MaxConcurrentReconciles: 1, | |||
| Reconciler: c, | |||
There was a problem hiding this comment.
Needed because latest ctrl runtime packages added validation and the reconcilier is added later on
QuentinBisson
force-pushed
the
master#release#v7.2.0
branch
from
2498e71
to
6eba8b6
Compare
QuentinBisson
approved these changes
Nov 15, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.