Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape HTML in linear output #62

Merged
merged 2 commits into from Mar 6, 2024
Merged

Escape HTML in linear output #62

merged 2 commits into from Mar 6, 2024

Conversation

marians
Copy link
Member

@marians marians commented Mar 6, 2024

What does this PR do?

This PR makes sure that special characters like ' and " are escaped in HTML.

This makes post-processing like https://github.com/giantswarm/docs/blob/main/scripts/update-helm-chart-reference/main.sh#L22 obsolete.

What is the effect of this change to users?

No user-facing change.

Should this change be mentioned in the release notes?

  • CHANGELOG.md has been updated (if it exists)

@marians marians self-assigned this Mar 6, 2024
@marians marians marked this pull request as ready for review March 6, 2024 11:11
@marians marians requested a review from a team as a code owner March 6, 2024 11:11
@marians marians changed the title Escape HTML Escape HTML in linear output Mar 6, 2024
@marians marians requested a review from pipo02mix March 6, 2024 11:11
Copy link

@lyind lyind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Time to remove the nasty workarounds. :)

@marians marians merged commit c539c01 into main Mar 6, 2024
2 checks passed
@marians marians deleted the escape-html branch March 6, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants