Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace flit by flit_core in build-system #205

Merged
merged 1 commit into from Aug 28, 2023
Merged

Replace flit by flit_core in build-system #205

merged 1 commit into from Aug 28, 2023

Conversation

tjni
Copy link
Contributor

@tjni tjni commented Aug 27, 2023

flit_core is the lighter weight PEP 517 build backend. This lets us build the package using a different front-end, such as build, without pulling in all of flit.

@codecov
Copy link

codecov bot commented Aug 27, 2023

Codecov Report

Merging #205 (35048fa) into main (735154e) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #205   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          471       471           
  Branches        87        87           
=========================================
  Hits           471       471           

@Mariatta
Copy link
Member

Thank you. Should we pin the minimum version of flit that supports this?

@tjni
Copy link
Contributor Author

tjni commented Aug 28, 2023

Great question. I locally was able to build the package using flit_core 2.0, which is the earliest released PyPI version, so I don't think it's technically necessary, but I don't mind increasing it either.

@brettcannon brettcannon merged commit 7474cae into gidgethub:main Aug 28, 2023
10 checks passed
@brettcannon
Copy link
Collaborator

Thanks, @tjni ! Since you verified a lower-bound isn't necessary I didn't worry about setting one.

@tjni tjni deleted the flit-core branch August 28, 2023 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants