Support negotiation wildcards, fix #391 #1112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1112 +/- ##
=========================================
+ Coverage 98.49% 98.5% +<.01%
=========================================
Files 41 41
Lines 2064 2070 +6
=========================================
+ Hits 2033 2039 +6
Misses 19 19
Partials 12 12
Continue to review full report at Codecov.
|
appleboy
requested review from
appleboy,
tboerger,
javierprovecho and
nazwa
appleboy
requested review from
thinkerou
and removed request for
tboerger and
nazwa
thinkerou
approved these changes
Feb 28, 2019
|
@appleboy please help review the pull request, thanks! |
appleboy
approved these changes
Feb 28, 2019
tmm1
reviewed
Feb 3, 2020
| @@ -1158,17 +1158,41 @@ func TestContextNegotiationFormat(t *testing.T) { | |||
| func TestContextNegotiationFormatWithAccept(t *testing.T) { | |||
| c, _ := CreateTestContext(httptest.NewRecorder()) | |||
| c.Request, _ = http.NewRequest("POST", "/", nil) | |||
| c.Request.Header.Add("Accept", "text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8") | |||
| c.Request.Header.Add("Accept", "text/html,application/xhtml+xml,application/xml;q=0.9;q=0.8") | |||
|
|
|||
| assert.Equal(t, MIMEXML, c.NegotiateFormat(MIMEJSON, MIMEXML)) | |||
| assert.Equal(t, MIMEHTML, c.NegotiateFormat(MIMEXML, MIMEHTML)) | |||
| assert.Empty(t, c.NegotiateFormat(MIMEJSON)) | |||
There was a problem hiding this comment.
This change is causing a regression in my app. What is the recommended way to achieve the previous behavior? I want to check if Accept explicitly contains MIMEJSON.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support negotiation wildcards, fix #391.