Serve easily dynamic files with DataFromReader context method
#1304
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1304 +/- ##
==========================================
+ Coverage 98.19% 98.21% +0.01%
==========================================
Files 34 35 +1
Lines 1826 1846 +20
==========================================
+ Hits 1793 1813 +20
Misses 26 26
Partials 7 7
Continue to review full report at Codecov.
|
jclebreton
changed the title
DataFromReader context method
|
@thinkerou Could you also help to review this PR? |
|
@appleboy @jclebreton Except for comments, LGTM to me. Thanks! |
| @@ -834,6 +834,32 @@ func main() { | |||
| } | |||
| ``` | |||
|
|
|||
| ### Serving data from reader | |||
There was a problem hiding this comment.
Please add content link in README, thanks!
There was a problem hiding this comment.
Hello @thinkerou I'm not sure to understand the target of the asked link. This page ?
There was a problem hiding this comment.
You should add [Serving data from reader](#serving-data-from-reader) after the line:
render/reader.go
Outdated
| // Render (Reader) writes data with custom ContentType and headers. | ||
| func (r Reader) Render(w http.ResponseWriter) (err error) { | ||
| r.WriteContentType(w) | ||
| r.Headers["Content-Length"] = fmt.Sprintf("%d", r.ContentLength) |
There was a problem hiding this comment.
Why not use strconv.Itoa(r.ContentLength)? Thanks!
There was a problem hiding this comment.
You're right. It's better to use strconv library but to convert a int64 variable to a string strconv.FormatInt(r.ContentLength, 10) works better ;)
jclebreton
force-pushed
the
data_from_reader
branch
2 times, most recently
from
68b44cf
to
157ffdb
Compare
render/render_test.go
Outdated
| "testing" | ||
|
|
||
| "strings" |
There was a problem hiding this comment.
remove the extra empty line between internal package.
jclebreton
force-pushed
the
data_from_reader
branch
from
157ffdb
to
9dca295
Compare
|
need @thinkerou approvl. |
|
LGTM |
| func (r Reader) writeHeaders(w http.ResponseWriter, headers map[string]string) { | ||
| header := w.Header() | ||
| for k, v := range headers { | ||
| if val := header[k]; len(val) == 0 { |
There was a problem hiding this comment.
Actually, I prefer to using val == "" for judging empty string.
There was a problem hiding this comment.
@jclebreton Please update and I will merge this.
|
Thanks for review and merge ;-) |
This pull request adds a new method called
DataFromReaderto provides an easy way to serve dynamic files.