Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yaml binding #1618

Merged
merged 6 commits into from Nov 6, 2018
Merged

Yaml binding #1618

merged 6 commits into from Nov 6, 2018

Conversation

doxxx
Copy link
Contributor

@doxxx doxxx commented Oct 31, 2018

This adds binding support for YAML.

Sidenote: testBodyBinding uses JSON.Bind instead of the Binding instance passed as a parameter when testing the badBody. Is this intended?

@codecov
Copy link

codecov bot commented Oct 31, 2018

Codecov Report

Merging #1618 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1618      +/-   ##
==========================================
+ Coverage   99.27%   99.28%   +<.01%     
==========================================
  Files          39       40       +1     
  Lines        1931     1948      +17     
==========================================
+ Hits         1917     1934      +17     
  Misses         10       10              
  Partials        4        4
Impacted Files Coverage Δ
binding/yaml.go 100% <100%> (ø)
binding/binding.go 100% <100%> (ø) ⬆️
context.go 99.49% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a374f9...bd0e767. Read the comment docs.

@doxxx
Copy link
Contributor Author

doxxx commented Oct 31, 2018

I'll take a look at improving the test coverage in the next day or so.

@appleboy appleboy added this to the 1.4 milestone Nov 1, 2018
context.go Show resolved Hide resolved
@thinkerou
Copy link
Member

@appleboy please update review comment and then LGTM, thanks!

binding/yaml.go Show resolved Hide resolved
@appleboy
Copy link
Member

appleboy commented Nov 5, 2018

@thinkerou Sorry. The external package has already in go.mod.

@thinkerou
Copy link
Member

@appleboy yes, no sweat.

@thinkerou thinkerou merged commit 8cb390f into gin-gonic:master Nov 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants