Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recovery: fix issue about syscall import on google app engine #1640

Merged
merged 5 commits into from Nov 22, 2018
Merged

recovery: fix issue about syscall import on google app engine #1640

merged 5 commits into from Nov 22, 2018

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Nov 12, 2018 •
edited

@thinkerou thinkerou mentioned this pull request Nov 12, 2018
Closed
@codecov
Copy link

codecov bot commented Nov 12, 2018 •
edited

Codecov Report

Merging #1640 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1640   +/-   ##
=======================================
  Coverage   99.29%   99.29%           
=======================================
  Files          40       40           
  Lines        1973     1973           
=======================================
  Hits         1959     1959           
  Misses         10       10           
  Partials        4        4
Impacted Files Coverage Δ
recovery.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d44ff8...d9c4346. Read the comment docs.

justinfx
justinfx previously approved these changes Nov 12, 2018
View reviewed changes
Copy link
Contributor

@justinfx justinfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was reviewing before you added the Lower, and was about to make that same suggestion since I saw mixed case between different OS/arch. Good call!

@sublee
Copy link

sublee commented Nov 21, 2018

Can it be merged?

@thinkerou
Copy link
Member Author

@sublee need @appleboy review and merged, thanks!

@appleboy appleboy added the bug label Nov 22, 2018
@appleboy appleboy added this to the 1.4 milestone Nov 22, 2018
@appleboy appleboy merged commit 7ec82ee into gin-gonic:master Nov 22, 2018
@appleboy
Copy link
Member

@justinfx @sublee merged.

@justinfx
Copy link
Contributor

thanks!

@sublee
Copy link

sublee commented Nov 22, 2018

Thank you!

@thinkerou thinkerou deleted the hm branch November 22, 2018 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@justinfx justinfx justinfx left review comments

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@thinkerou @sublee @appleboy @justinfx