Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: break when test fail #1671

Merged
merged 3 commits into from Dec 5, 2018
Merged

ci: break when test fail #1671

merged 3 commits into from Dec 5, 2018

Conversation

thinkerou
Copy link
Member

@thinkerou thinkerou commented Nov 27, 2018

closes #1670 #1656

please @appleboy review the scheme, and fail case have fixed #1669 , please first review and merge it, thanks!

@thinkerou thinkerou added this to the 1.4 milestone Nov 27, 2018
@thinkerou thinkerou added the bug label Nov 27, 2018
@thinkerou
Copy link
Member Author

thinkerou commented Dec 5, 2018

#1682 need to merged first.

@codecov
Copy link

codecov bot commented Dec 5, 2018

Codecov Report

Merging #1671 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1671      +/-   ##
==========================================
- Coverage   99.39%   99.19%   -0.21%     
==========================================
  Files          41       41              
  Lines        1995     1995              
==========================================
- Hits         1983     1979       -4     
- Misses          9       12       +3     
- Partials        3        4       +1
Impacted Files Coverage Δ
logger.go 94.93% <0%> (-5.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 98c7ac7...19a2e38. Read the comment docs.

@appleboy appleboy merged commit cce4958 into gin-gonic:master Dec 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to break test when go test FAIL?
2 participants