Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix errcheck warnings #1739

Merged
merged 1 commit into from Jan 18, 2019
Merged

fix errcheck warnings #1739

merged 1 commit into from Jan 18, 2019

Conversation

vkd
Copy link
Contributor

@vkd vkd commented Jan 9, 2019 •
edited

Fix all warnings after run golangci-lint run --disable-all -E errcheck
Fix #1738 #1247

@appleboy appleboy added this to the 1.4 milestone Jan 18, 2019
@thinkerou thinkerou merged commit b056a34 into gin-gonic:master Jan 18, 2019
@thinkerou thinkerou mentioned this pull request Jan 20, 2019
Closed
@chainhelen chainhelen mentioned this pull request Jan 28, 2019
Closed
@vkd vkd deleted the errcheck branch March 26, 2019 18:25
@thinkerou thinkerou mentioned this pull request Jun 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@thinkerou thinkerou thinkerou approved these changes

@javierprovecho javierprovecho Awaiting requested review from javierprovecho

Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
1.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vkd @appleboy @thinkerou