Attempt to fix #1927 #1931
Merged
Attempt to fix #1927 #1931
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1931 +/- ##
==========================================
+ Coverage 98.75% 98.75% +<.01%
==========================================
Files 38 38
Lines 2172 2173 +1
==========================================
+ Hits 2145 2146 +1
Misses 15 15
Partials 12 12
Continue to review full report at Codecov.
|
|
@thinkerou nice find this looks safe and needed! |
|
Will this fix also this case with files where files would be "cached" too? form, _ := c.MultipartForm()
files := form.File["upload"] |
appleboy
approved these changes
Jun 12, 2019
|
@crazywako can you help me check? thanks! |
Will test in the next 24 hours. |
|
@thinkerou Couldn't reproduce the problem anymore. So it seems fixed. I will open a issue if I find out the issue is still there. |
|
@crazywako thanks!!! 💯 |
ThomasObenaus
pushed a commit
to ThomasObenaus/gin
that referenced
this pull request
Feb 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.