Drop Support for go1.8 and go1.9 #1933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1933 +/- ##
=========================================
- Coverage 98.77% 98.68% -0.1%
=========================================
Files 40 40
Lines 2212 2212
=========================================
- Hits 2185 2183 -2
- Misses 15 16 +1
- Partials 12 13 +1
Continue to review full report at Codecov.
|
|
@thinkerou @appleboy It seems the PR get passed. Could you merge it? If it hasn’t merge, it will postpone #1939 ‘s merge. |
thinkerou
approved these changes
Jun 28, 2019
|
@appleboy @japettyjohn Please review the PR. thx |
appleboy
approved these changes
Jun 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the updates for fix #1912