Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade github.com/ugorji/go/codec #1969

Merged
merged 2 commits into from Jul 9, 2019
Merged

upgrade github.com/ugorji/go/codec #1969

merged 2 commits into from Jul 9, 2019

Conversation

thinkerou
Copy link
Member

ref: #1673

@thinkerou thinkerou requested a review from appleboy July 3, 2019 02:40
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #1969 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1969   +/-   ##
=======================================
  Coverage   98.69%   98.69%           
=======================================
  Files          40       40           
  Lines        2218     2218           
=======================================
  Hits         2189     2189           
  Misses         16       16           
  Partials       13       13

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e602d52...fe53c08. Read the comment docs.

@AndreiD
Copy link

AndreiD commented Jul 5, 2019

anyone wants to take a look at this please :)

@appleboy appleboy added this to the 1.5 milestone Jul 9, 2019
@thinkerou thinkerou merged commit 0349de5 into gin-gonic:master Jul 9, 2019
@jimanvlad
Copy link

Still get similar when using gin via go modules:

build command-line-arguments: cannot load github.com/ugorji/go/codec: ambiguous import: found github.com/ugorji/go/codec in multiple modules:
        github.com/ugorji/go v1.1.4 (/Users/jimanv/go/pkg/mod/github.com/ugorji/go@v1.1.4/codec)
        github.com/ugorji/go/codec v0.0.0-20181209151446-772ced7fd4c2 (/Users/jimanv/go/pkg/mod/github.com/ugorji/go/codec@v0.0.0-20181209151446-772ced7fd4c2)

@appleboy
Copy link
Member

@jimanvlad try go get github.com/gin-gonic/gin@master

@jimanvlad
Copy link

Works after explicit go get but assumed this pull request would have fixed the download automatically

ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants