Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade go-validator to v10 #2149

Merged
merged 3 commits into from Nov 25, 2019
Merged

upgrade go-validator to v10 #2149

merged 3 commits into from Nov 25, 2019

Conversation

fifsky
Copy link
Contributor

@fifsky fifsky commented Nov 25, 2019

fix #2130

The only difference between v10 and v9 is the package path

@thinkerou
Copy link
Member

$make vet
go vet github.com/gin-gonic/gin github.com/gin-gonic/gin/binding github.com/gin-gonic/gin/ginS github.com/gin-gonic/gin/internal/json github.com/gin-gonic/gin/render
The command "make vet" exited with 0.
0.27s$ make fmt-check
Please run 'make fmt' and commit the result:
diff -u ./binding/validate_test.go.orig ./binding/validate_test.go
--- ./binding/validate_test.go.orig	2019-11-25 02:23:09.994483229 +0000
+++ ./binding/validate_test.go	2019-11-25 02:23:09.994483229 +0000
@@ -9,8 +9,8 @@
 	"testing"
 	"time"
 
-	"github.com/stretchr/testify/assert"
 	"github.com/go-playground/validator/v10"
+	"github.com/stretchr/testify/assert"
 )
 
 type testInterface interface {
Makefile:41: recipe for target 'fmt-check' failed

@thinkerou thinkerou self-requested a review November 25, 2019 03:26
@codecov
Copy link

codecov bot commented Nov 25, 2019

Codecov Report

Merging #2149 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2149   +/-   ##
=======================================
  Coverage   98.61%   98.61%           
=======================================
  Files          40       40           
  Lines        2238     2238           
=======================================
  Hits         2207     2207           
  Misses         16       16           
  Partials       15       15
Impacted Files Coverage Δ
binding/default_validator.go 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3737520...060ba3c. Read the comment docs.

@thinkerou thinkerou added this to the 1.6 milestone Nov 25, 2019
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkerou thinkerou merged commit e90e2ba into gin-gonic:master Nov 25, 2019
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* upgrade go-validator to v10

* fix fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please upgrade go-validator to v10
3 participants