Fix "Custom Validators" example #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
mosdeo
commented
Dec 16, 2019
•
mosdeo
commented
- Update fixed code.
- Fix incorrect date for testing & demo.
According to [this](gin-gonic/examples@874dcfa) merged commit.
Original testing date incompatible demo require, can't get expect result. check_in date need NOT AFTER check_out date.
Codecov Report
@@ Coverage Diff @@
## master #2186 +/- ##
=======================================
Coverage 98.49% 98.49%
=======================================
Files 40 40
Lines 2257 2257
=======================================
Hits 2223 2223
Misses 18 18
Partials 16 16Continue to review full report at Codecov.
|
thinkerou
approved these changes
Dec 18, 2019
This was referenced Dec 18, 2019
thinkerou
pushed a commit
that referenced
this pull request
Dec 18, 2019
Excuse me, I forgot change output in #2186
thinkerou
pushed a commit
to gin-gonic/website
that referenced
this pull request
Dec 18, 2019
Update fixed 500 err and incorrect testing date & output in demo. - gin-gonic/gin#2186 - gin-gonic/examples#25
|
@mosdeo sorry, now the master branch have upgraded to v10 not v9, please re-commit the pull request to fix it, thanks! |
I tried it few minutes ago, change to v10 have nothing different, I will modify it from repository "gin-gonic/examples". |
ThomasObenaus
pushed a commit
to ThomasObenaus/gin
that referenced
this pull request
Feb 19, 2020
* Update fixed error code from merged commit According to [this](gin-gonic/examples@874dcfa) merged commit. * Fixed incorrect testing date. Original testing date incompatible demo require, can't get expect result. check_in date need NOT AFTER check_out date.
ThomasObenaus
pushed a commit
to ThomasObenaus/gin
that referenced
this pull request
Feb 19, 2020
Excuse me, I forgot change output in gin-gonic#2186
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.