Update docs on Context.Done(), Context.Deadline() and Context.Err() #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2196 +/- ##
=======================================
Coverage 98.51% 98.51%
=======================================
Files 41 41
Lines 2284 2284
=======================================
Hits 2250 2250
Misses 18 18
Partials 16 16
Continue to review full report at Codecov.
|
appleboy
approved these changes
Jan 7, 2020
ThomasObenaus
pushed a commit
to ThomasObenaus/gin
that referenced
this pull request
Feb 19, 2020
…in-gonic#2196) Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
byebyebruce
pushed a commit
to byebyebruce/gin
that referenced
this pull request
Mar 25, 2020
…in-gonic#2196) Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has been discussed here #1452, here #1690, here #1736, here #2029, in my opinion, wether current behavior will be changed or not, current documentation doesn't match with real behavior, so it (documentation) has to be changed.
This is my view of what it should look like.