Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renew README to fit the modification of SetCookie method #2217

Merged
merged 1 commit into from Jan 22, 2020
Merged

Renew README to fit the modification of SetCookie method #2217

merged 1 commit into from Jan 22, 2020

Conversation

panjf2000
Copy link
Contributor

fix #2214

@codecov
Copy link

codecov bot commented Jan 22, 2020 •
edited

Codecov Report

Merging #2217 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2217   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          41       41           
  Lines        2287     2287           
=======================================
  Hits         2253     2253           
  Misses         18       18           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 69a202d...999d49f. Read the comment docs.

@panjf2000
Copy link
Contributor Author

panjf2000 commented Jan 22, 2020 •
edited

BTY, incompatible changes like that might breaks lots of codebase, maybe functional options could be considered to be the solution for those constructions with many optional arguements in the future, just a suggestion.

@appleboy appleboy added this to the 1.6 milestone Jan 22, 2020
@appleboy appleboy merged commit 07c0f05 into gin-gonic:master Jan 22, 2020
@panjf2000 panjf2000 deleted the patch-1 branch February 9, 2020 12:06
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
@panjf2000 @ThomasObenaus
Renew README to fit the modification of SetCookie method (gin-gonic#2217
938dce2 
)

fix gin-gonic#2214
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
@panjf2000 @byebyebruce
Renew README to fit the modification of SetCookie method (gin-gonic#2217
d097a16 
)

fix gin-gonic#2214
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

Assignees
No one assigned
Labels
document
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

SetCookie broken
2 participants
@panjf2000 @appleboy