Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(path): improve comments #2223

Merged
merged 2 commits into from Jan 28, 2020
Merged

docs(path): improve comments #2223

merged 2 commits into from Jan 28, 2020

Conversation

appleboy
Copy link
Member

@appleboy appleboy added this to the 1.6 milestone Jan 27, 2020
@appleboy appleboy changed the title chore(path): improve comments docs(path): improve comments Jan 27, 2020
Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
@codecov
Copy link

codecov bot commented Jan 27, 2020

Codecov Report

Merging #2223 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2223   +/-   ##
=======================================
  Coverage   98.51%   98.51%           
=======================================
  Files          41       41           
  Lines        2287     2287           
=======================================
  Hits         2253     2253           
  Misses         18       18           
  Partials       16       16
Impacted Files Coverage Δ
path.go 100% <ø> (ø) ⬆️
tree.go 99.14% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07c0f05...7dfabd2. Read the comment docs.

@thinkerou thinkerou merged commit 64e6a76 into master Jan 28, 2020
@thinkerou thinkerou deleted the path branch February 1, 2020 06:03
ThomasObenaus pushed a commit to ThomasObenaus/gin that referenced this pull request Feb 19, 2020
* chore(path): improve comments

copy from julienschmidt/httprouter@15782a7

* fix typo

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
* chore(path): improve comments

copy from julienschmidt/httprouter@15782a7

* fix typo

Signed-off-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants