Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use json marshall in context json to fix breaking new line issue. Fixes #2209 #2228

Merged
merged 5 commits into from Feb 21, 2020
Merged

Use json marshall in context json to fix breaking new line issue. Fixes #2209 #2228

merged 5 commits into from Feb 21, 2020

Conversation

KaushikNeelichetty
Copy link
Contributor

Fixes the issue #2209

@codecov
Copy link

codecov bot commented Feb 7, 2020 •
edited

Codecov Report

Merging #2228 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2228   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          41       41           
  Lines        2290     2290           
=======================================
  Hits         2253     2253           
  Misses         21       21           
  Partials       16       16

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 176488c...524a650. Read the comment docs.

@appleboy appleboy added the bug label Feb 7, 2020
@appleboy appleboy added this to the 1.6 milestone Feb 7, 2020
@appleboy appleboy linked an issue Feb 7, 2020 that may be closed by this pull request
context.JSON adds a new line to end of JSON response #2209
Closed
@thinkerou
Copy link
Member

related #1546

@KaushikNeelichetty
Copy link
Contributor Author

Requesting your help @appleboy @thinkerou

The first check codecov/project fails with a delta of 0.02%.

From the details available here , I can see that the coverage diff is in binding/binding_nomsgpack.go.

I don't think this PR affects that file (to my knowledge binding is the reverse of WriteJSON)

The check codecov/patch passes with 100%. So I have covered all places that are affected by my changes.

Kindly let me know on what I am missing here.

appleboy
appleboy requested changes Feb 15, 2020
View reviewed changes
.gitignore Outdated Show resolved Hide resolved
@appleboy
Copy link
Member

need @thinkerou review.

thinkerou
thinkerou approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thinkerou thinkerou merged commit 5f56109 into gin-gonic:master Feb 21, 2020
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
@KaushikNeelichetty @appleboy
@thinkerou @byebyebruce
Use json marshall in context json to fix breaking new line issue. Fixes
a760db8 
gin-gonic#2209 (gin-gonic#2228)

* ignore IntelliJ idea generated files

* update JSON renderer to use Marshall() instead of Encode(). Fix gin-gonic#2209

* Revert "ignore IntelliJ idea generated files"

This reverts commit e7bd017.

Co-authored-by: Bo-Yi Wu <appleboy.tw@gmail.com>
Co-authored-by: thinkerou <thinkerou@gmail.com>
@akijakya akijakya mentioned this pull request Jan 25, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@appleboy appleboy appleboy approved these changes

@thinkerou thinkerou thinkerou approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
1.6
Development

Successfully merging this pull request may close these issues.

context.JSON adds a new line to end of JSON response
3 participants
@KaushikNeelichetty @thinkerou @appleboy