Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mitigation for log injection #2277

Merged
merged 2 commits into from Mar 7, 2020
Merged

Add mitigation for log injection #2277

merged 2 commits into from Mar 7, 2020

Conversation

manute
Copy link
Contributor

@manute manute commented Mar 3, 2020

Copy #2265 and fix the tests

@codecov
Copy link

codecov bot commented Mar 3, 2020

Codecov Report

Merging #2277 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2277   +/-   ##
=======================================
  Coverage   98.38%   98.38%           
=======================================
  Files          41       41           
  Lines        2296     2296           
=======================================
  Hits         2259     2259           
  Misses         21       21           
  Partials       16       16
Impacted Files Coverage Δ
logger.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d055af...e162605. Read the comment docs.

@manute
Copy link
Contributor Author

manute commented Mar 3, 2020

cc @appleboy @thinkerou

@appleboy appleboy added this to the 1.6 milestone Mar 7, 2020
@thinkerou thinkerou merged commit a71af9c into gin-gonic:master Mar 7, 2020
pull bot pushed a commit to scope-demo/gin that referenced this pull request Mar 7, 2020
Co-authored-by: thinkerou <thinkerou@gmail.com>
byebyebruce pushed a commit to byebyebruce/gin that referenced this pull request Mar 25, 2020
Co-authored-by: thinkerou <thinkerou@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants