Unix Socket Handling #2280
Merged
Unix Socket Handling #2280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2280 +/- ##
==========================================
+ Coverage 98.38% 98.47% +0.08%
==========================================
Files 41 41
Lines 2296 2293 -3
==========================================
- Hits 2259 2258 -1
+ Misses 21 20 -1
+ Partials 16 15 -1
Continue to review full report at Codecov.
|
appleboy
requested changes
Mar 13, 2020
gin.go
Outdated
| listener, err := net.Listen("unix", file) | ||
| if err != nil { | ||
| return | ||
| } | ||
| defer listener.Close() | ||
| err = os.Chmod(file, 0777) | ||
| defer os.Remove(file) | ||
|
|
||
| if err != nil { |
appleboy
approved these changes
Mar 16, 2020
pull bot
pushed a commit
to scope-demo/gin
that referenced
this pull request
Mar 16, 2020
* do not set unix socket permissions. Cleanup unix socket. * removed useless error checking
byebyebruce
pushed a commit
to byebyebruce/gin
that referenced
this pull request
Mar 25, 2020
* do not set unix socket permissions. Cleanup unix socket. * removed useless error checking
|
How can I set the socket file permissions to set it group-writable so that my go program and webserver reading/writing the socket do not need to share the same user? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current handling of Unix sockets is not correct.
One of the main reasons to use sockets is for security. Using sockets allows you to lock access down to a specific unix group/user.However, due to the various use cases for unix sockets, it may be a good idea to accept a
net.Listenerinterface, so that the socket can be configured before the server is started.