Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve linting, testing, and GitHub Actions setup #3583

Merged
merged 1 commit into from Apr 26, 2023
Merged

chore: improve linting, testing, and GitHub Actions setup #3583

merged 1 commit into from Apr 26, 2023

Conversation

appleboy
Copy link
Member

@appleboy appleboy commented Apr 26, 2023 •
edited

  • Update golangci-lint version from v1.48.0 to v1.52.2
  • Remove Gitter notifications from GitHub Actions workflow
  • Add gosec linter settings and include specific rules
  • Exclude revive linter for test files
  • Remove Gitter badge from README.md
  • Delete codecov.yml file
  • Change function parameter name in fs.go
  • Remove unused parameter in defaultHandleRecovery function

@appleboy appleboy added this to the v1.10 milestone Apr 26, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023 •
edited

Codecov Report

Merging #3583 (8adadf8) into master (a889c58) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #3583   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          42       42           
  Lines        3151     3151           
=======================================
  Hits         3108     3108           
  Misses         29       29           
  Partials       14       14
Flag Coverage Δ
98.63% <100.00%> (ø)
go-1.18 98.54% <100.00%> (ø)
go-1.19 98.63% <100.00%> (ø)
go-1.20 98.63% <100.00%> (ø)
macos-latest 98.63% <100.00%> (ø)
ubuntu-latest 98.63% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fs.go 100.00% <100.00%> (ø)
gin.go 99.19% <100.00%> (ø)
recovery.go 98.11% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@appleboy appleboy requested a review from thinkerou April 26, 2023 03:56
@appleboy
chore: improve linting, testing, and GitHub Actions setup
8adadf8 
- Update golangci-lint version from `v1.48.0` to `v1.52.2`
- Remove Gitter notifications from GitHub Actions workflow
- Add gosec linter settings and include specific rules
- Exclude revive linter for test files
- Remove Gitter badge from README.md
- Delete codecov.yml file
- Change function parameter name in fs.go
- Remove unused parameter in defaultHandleRecovery function

Signed-off-by: appleboy <appleboy.tw@gmail.com>
@appleboy appleboy changed the title chore: introduce linters and remove unused code in file handling functions chore: improve linting, testing, and GitHub Actions setup Apr 26, 2023
thinkerou
thinkerou approved these changes Apr 26, 2023
View reviewed changes
Copy link
Member

@thinkerou thinkerou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks 👍

@thinkerou thinkerou merged commit 757a638 into gin-gonic:master Apr 26, 2023
29 checks passed
@appleboy appleboy deleted the lint branch April 26, 2023 08:56
This was referenced Apr 27, 2023
Merged
Closed
@thinkerou thinkerou modified the milestones: v1.10, v1.9.1 Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thinkerou thinkerou thinkerou approved these changes

Assignees
No one assigned
Labels
continuous-integration enhancement
Projects
None yet
Milestone
v1.9.1
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@appleboy @thinkerou