3577 sec fix #3597
Closed
3577 sec fix #3597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let me know if this PR needs more work. |
YuukanOO
reviewed
Jun 15, 2023
| // Add type checking for the callback function name | ||
| // Use a Unicode-aware pattern for alphanumeric characters and underscores | ||
| callbackPattern := `^[\p{L}\p{N}_]+$` | ||
| isValidCallback := regexp.MustCompile(callbackPattern).MatchString(callback) |
There was a problem hiding this comment.
You should move the callbackPattern and the regex MustCompile in a package level variable to avoid the cost of rebuilding it everytime.
YuukanOO
reviewed
Jun 15, 2023
| jsonString, _ := json.Marshal(anyData) | ||
|
|
||
| // Respond with a JavaScript callback function call that includes the JSON data | ||
| c.Render(code, render.String{Format: "/**/ typeof " + callback + " === 'function' && " + callback + "(%s);", Data: []interface{}{string(jsonString)}}) |
There was a problem hiding this comment.
The render logic should probably be moved to the render package by leveraging the JsonpJSON struct (in particular https://github.com/gin-gonic/gin/blob/master/render/json.go#LL116C13-L116C13).
|
outdated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added type checking to JSONP for security reasons.
Added mention in documentation.
Added test function.