Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added go-install installation option #232

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

GhoulKingR
Copy link

Fixes issue #231

@diegolikescode
Copy link

hey, this is a important one!

I would say that you could add more information based on the golang doc, like "Go 1.18 and beyond doesn't support go get, so you must use go install" or something, but no one ever respond to this PR... come on guys, lets update deeze docs

@GhoulKingR
Copy link
Author

Hey @diegolikescode, what if I added that information as code comments in the step 1 code block.

Something like this:

$ go get -u github.com/gin-gonic/gin

# Or

$ go install github.com/gin-gonic/gin@latest

# for Go 1.18 and beyond

You can also check the issue linked to this PR, it says that running the command under go modules works.

@diegolikescode
Copy link

@GhoulKingR honestly for me it is good to go, but it must be approved to update te official docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants