Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference issues/PRs
None
Types of changes
Description
Currently, the minus i-th entry in
SlidingWindow().resample(y)
is the last element from the minus i-th full window.This PR offers a generalization, where
SlidingWindow.target_resampler
is applied toSlidingWindow().transform(y)[i]
to obtainSlidingWindow().resample(y)[i]
.The default
SlidingWindow.target_resampler=lambda x: x[-1]
makes the default behavior unchanged.Screenshots (if appropriate)
Any other comments?
I am not sure if this is the right place to introduce that. Maybe another transformer, which inherits from Sliding window would be better?
Checklist
flake8
to check my Python changes.pytest
to check this on Python tests.