Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deployment of documentation on merge #505

Draft
wants to merge 16 commits into
base: master
Choose a base branch
from

Conversation

wreise
Copy link
Collaborator

@wreise wreise commented Sep 27, 2020

Reference issues/PRs
Continuation of #383 , updated with the latest state of the docs pipeline.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Description
Add a step to automatically publish docs on merge.

Screenshots (if appropriate)

Any other comments?

Checklist

  • I have read the guidelines for contributing.
  • My code follows the code style of this project. I used flake8 to check my Python changes.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed. I used pytest to check this on Python tests.

@wreise wreise changed the title Docs/deployment Deployment of documentation on merge Sep 27, 2020
@wreise
Copy link
Collaborator Author

wreise commented Jan 20, 2021

I think it would greatly help if we kept the list of versions up to date, so as we just aways run update-versions, without updating the list itself in the deployment process. We already did that for the last releases, so I suggest to keep it that way.

Regarding notebooks, I get some errors in the MNIST, which i do not locally. It also makes me think whether we could publish the artifacts from the notebook tests, instead of doing running them again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant