Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yarn upgrade all packages to latest #266

Merged
merged 4 commits into from Jul 21, 2020
Merged

Yarn upgrade all packages to latest #266

merged 4 commits into from Jul 21, 2020

Conversation

zachmullen
Copy link
Member

This changeset is just a result of running yarn upgrade -L. The demo app builds and runs cleanly.

@zachmullen
Copy link
Member Author

Except for @vue/test-utils, which doesn't work on the latest version. That will require a separate investigation, because I have no idea why our tests are failing there.

@zachmullen
Copy link
Member Author

TODO need to update our linter rules

@zachmullen
Copy link
Member Author

This line breaks eslint... not sure what's up there.

@zachmullen
Copy link
Member Author

Relevant thread: airbnb/javascript#2227

@zachmullen zachmullen requested a review from subdavis June 20, 2020 15:47
@subdavis
Copy link
Contributor

@zachmullen might as well bump the package version in package.json ?

@zachmullen zachmullen merged commit deea486 into master Jul 21, 2020
@zachmullen zachmullen deleted the full-yarn-upgrade branch July 21, 2020 18:56
subdavis pushed a commit that referenced this pull request Jul 21, 2020
Yarn upgrade all packages to latest
zachmullen added a commit that referenced this pull request Jul 21, 2020
This could not be done on #266 due to an upstream eslint bug,
but that has since been fixed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants