Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.3.1 #300

Merged
merged 1 commit into from
Jan 7, 2021
Merged

v2.3.1 #300

merged 1 commit into from
Jan 7, 2021

Conversation

scottwittenburg
Copy link
Contributor

No description provided.

@zachmullen zachmullen merged commit 47833c6 into girder:master Jan 7, 2021
@zachmullen
Copy link
Member

Tag has been pushed. 2.3.1 should be published in a few minutes.

@scottwittenburg scottwittenburg deleted the cut-v2.3.1 branch January 7, 2021 18:12
subdavis pushed a commit that referenced this pull request Jan 7, 2021
@scottwittenburg
Copy link
Contributor Author

Tag has been pushed. 2.3.1 should be published in a few minutes.

Thanks for the lightning fast action @zachmullen 😁

@subdavis
Copy link
Contributor

subdavis commented Jan 7, 2021

@scottwittenburg @zachmullen 2.3 was an unintended release, and I was planning to scrub it from NPM pending a discussion.

The changes introduced in #293 are significant enough to require a major version update, so I was going to suggest moving to 3.0.0 after #297 gets resolved, which I haven't had time to fix.

Do you need the changes introduced in 2.3.0 (ts, import restructure)?

We can certainly keep going with 2.3, but it would somewhat contradict semver guidelines.

@subdavis
Copy link
Contributor

subdavis commented Jan 7, 2021

I see, the point was to release the changes from #299.

@scottwittenburg you should know that upgrading to 2.3 will break your project.

This library hasn't had so much traffic that it has been necessary to maintain a "stable" branch and a "next" branch to allow us to push minor patches like #299 while working on larger changes.

Apologies for the confusion. Let me know what you want do now.

@zachmullen
Copy link
Member

I don't have a strong preference.

@scottwittenburg
Copy link
Contributor Author

@subdavis We're currently on 2.2.6 and we're only using only the user login/registration dialog in our application, I don't think we necessarily need anything from 2.3, other than the newer axios. And based on your last comment, it sounds like getting that change will require some other work.

Other than that, I don't have any preference which path you take. But when you decide what you're going to do, I'll get in touch about the path forward for my application. Thanks!

@subdavis
Copy link
Contributor

subdavis commented Jan 7, 2021

Unless someone has a better suggestion, I'm going to

@scottwittenburg
Copy link
Contributor Author

  • Write a short migration guide (should be easy, just have to change import paths)

That would be great, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants