Static REST endpoint mode for invoking CLI tasks #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the ingestion process for tasks. Rather than parsing the CLI specs on the server, the client can use a script to parse them locally and send up the output to the server.
zachmullen
force-pushed
the
static-rest-endpoint
branch
2 times, most recently
from
5cfb997
to
9d90439
Compare
zachmullen
force-pushed
the
static-rest-endpoint
branch
from
9d90439
to
e9bbe44
Compare
manthey
reviewed
Jul 3, 2023
slicer_cli_web/docker_resource.py
Outdated
| @@ -62,7 +65,35 @@ def __init__(self, name): | |||
|
|
|||
| self.route('GET', ('path_match', ), self.getMatchingResource) | |||
|
|
|||
| self._generateAllItemEndPoints() | |||
| if os.environ.get('GIRDER_STATIC_REST_ONLY'): | |||
| self.route('POST', (':id', 'run'), self.runCli) | |||
There was a problem hiding this comment.
The endpoints that are generated elsewhere are self.route('POST', ('cli', ':id', 'run'), self.runCli). I think the tests are passing because when we upload or refresh a CLI, it is still invoking addRestEndpoints which adds these.
Further, some CLIs can expose an point like POST cli/:id/datalist/:key which also need to be handled (this endpoint is used, for instance, by the MONAI label CLI docker to fetch names of available segmentation models).
There was a problem hiding this comment.
Good catch, thanks!
It's true that this is not yet tested.
zachmullen
force-pushed
the
static-rest-endpoint
branch
from
1cbaad9
to
d5a93a5
Compare
|
This branch is deployed here https://histomics-demo.com/api/v1#/slicer95cli95web |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides an off-by-default mode for Slicer CLI web with an alternate mode of supporting CLI task execution in share-nothing deployments. By setting
GIRDER_STATIC_REST_ONLY=truein the environment, this mode is enabled. As written, it has the following limitations:datalistoperation.With this change, the web server will now be able to execute newly-added Slicer CLI task items without the need for a manual server restart.