-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: go template function uniqueOlderCommits/uniqueNewerCommits is available #211
base: master
Are you sure you want to change the base?
Conversation
f6b799b
to
2362232
Compare
2362232
to
66541c9
Compare
@ikedam thank you for the PR. Could you rebase it onto the latest |
@mavogel Sounds strange. I can't get what you want. |
hi @ikedam to see of the tests and linting still pass with the updated versions of the |
@mavogel |
|
Let's try reopen. |
Hmm... not triggered. OK. I'll rebase this. |
…vailable * They allow to remove duplicated log entries. Closes git-chglog#29
66541c9
to
5f46006
Compare
https://github.com/git-chglog/git-chglog/actions/runs/3995523177
|
But the message changed to
and differs from the one before rebasing. Something wrong looked happen inside github. Anyway, rebase completed. |
ah now I got the approve run button and pushed it :) |
Pull Request Test Coverage Report for Build 3995523177
💛 - Coveralls |
Closes #29
What does this do / why do we need it?
uniqueOlderCommits
anduniqueNewerCommits
. They removes duplicated commits / log entries. "Duplicated" is evaluated withfields
specified. For example, if your changelog entries consists of.Scope
and.Subject
,(uniqueOlderCommits .Commits "Scope" "Subject")
is expected.We can rewrite
.chglog/CHANGELOG.tpl.md
ingit-chglog
like this:How this PR fixes the problem?
Commit
to remove duplication.Commit
. For example, "Scope" and "Subject". Or it may beJiraIssueID
(for the case only one entry for one ticket).uniqueOlderCommits
anduniqueNewerCommits
resolves that.What should your reviewer look out for in this PR?
README.md
. This feature is too complicated for my English.Check lists
Additional Comments (if any)
Older
andNewer
means the commit order. I believe we also need fix: the sort order of commits is unstable #210 to have this feature fully functioned.Which issue(s) does this PR fix?
fixes #29