use a Co-authored-by: message in git duet and git as #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gedaiu I forgot we require commits to be signed, do you mind signing this one? https://docs.github.com/articles/about-gpg/ |
gedaiu
force-pushed
the
master
branch
3 times, most recently
from
bbe1fc8
to
ef93e14
Compare
|
done |
jszwedko
approved these changes
Feb 12, 2022
jszwedko
reviewed
Feb 12, 2022
| git duet-commit -q -m 'Testing set of omega as committer' | ||
| run git log -1 --format='%cn <%ce>' | ||
| assert_success 'Frances Bar <f.bar@hamster.info.local>' | ||
| assert_success 'Zubaz Shirts <z.shirts@pika.info.local>' |
There was a problem hiding this comment.
This line is failing since git log -1 --format='%cn <%ce>' only returns the committer. I'm wondering if you meant to add this test at all? I would have expected just to see the ones in git-duet and git-as given the change here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's a little bit confusing that you don't see all the authors when you run
git duetandgit as. This change will make this less confusing :)