winpty: auto-detect redirects of stdin/stdout #415
Conversation
|
That's an interesting idea! However, I would like to see this in I'd be totally willing to carry a patch in What I have in mind is a new option that opts out of this new handling, so that by default we're checking What do you think @rimrul? |
Running commands through winpty with a redirected stdin or stdout only leads to error messages, that are at best not very helpfull to users and at worst outright confusing users. We can do better by adding a thin wrapper script that detects when it is and isn't appropriate to run a command through winpty and acts accordingly. Signed-off-by: Matthias Aßhauer <mha1993@live.de>
I've assumed the performance impact to be negligible when executing a shell script in bash, but you're probably right, this is probably a whole new bash proccess, just for this.
That definitely sounds plausible.
I'll see what I can do. |
Thank you! |
Running commands through
winptywith a redirectedstdinorstdoutonly leads to error messages, that are at best not veryhelpful to users and at worst outright confusing users.
We can do better by adding a thin wrapper script that detects
when it is and isn't appropriate to run a command through
winptyand acts accordingly.
This is an alternative to #414 that doesn't use undocumented options and shouldn't cause commands to think they're outputting to a console when they aren't.