Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock creation date to 'git lfs locks' output #4109

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add lock creation date to 'git lfs locks' output #4109

wants to merge 1 commit into from

Conversation

slonopotamus
Copy link
Contributor

No description provided.

@slonopotamus
Copy link
Contributor Author

CI failure isn't caused by changes in this PR.

@chrisd8088 chrisd8088 mentioned this pull request Apr 28, 2020
Merged
bk2204
bk2204 reviewed Apr 29, 2020
View reviewed changes
Copy link
Member

@bk2204 bk2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a fine change. Could we get some integration tests for it?

Also, I think we've fixed the CI problem, so if you rebase on master when you add the tests, I think that should pick up the fix.

@slonopotamus
Copy link
Contributor Author

Before doing that, I have a question: is there any way to list locks in machine-friendly format? If no, people might parse output of git lfs locks and we would break them, so it would be safer to move lock creation timestamp to the last column.

@bk2204
Copy link
Member

bk2204 commented Apr 29, 2020

There is a --json option. I did check that before responding. Although, since you mention it, putting it at the end would be a good idea for folks who don't want to use JSON, so if we can, let's do that.

bk2204
bk2204 reviewed May 6, 2020
View reviewed changes
Copy link
Member

@bk2204 bk2204 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this looks good.

Could we get some integration tests (maybe in t-locks.sh)? I realize that we may need to perform regex-based matching, which is fine, but I'd like to make sure we don't regress things.

Base automatically changed from master to main February 2, 2021 16:36
Plataformaalgoritmica
Plataformaalgoritmica reviewed Mar 1, 2022
View reviewed changes
Copy link

@Plataformaalgoritmica Plataformaalgoritmica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hola mundo soy Max,sugerencia de refuerzo de seguridad.

@Plataformaalgoritmica

This comment was marked as off-topic.

Sign in to view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bk2204 bk2204 bk2204 left review comments

@Plataformaalgoritmica Plataformaalgoritmica Plataformaalgoritmica left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@slonopotamus @bk2204 @Plataformaalgoritmica