Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Needs work] Allow specifying custom shelveset base for shelve command #1223

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nanoant
Copy link

@nanoant nanoant commented Oct 11, 2018

For example:

 git-tfs shelve "Experiment v1" experiments experiment-1

This will populate changes starting from experiments ref, rather than
last TFS check-in ref.

NOTE: While existing tests pass, I did not add any new tests, the reason being is that I have no idea how to Mock two refs, still I have tested it in real-life scenario and it works fine for me.

For example:

  git-tfs shelve "Experiment v1" experiments experiment-1

  This will populate changes starting from experiments ref, rather than
  last TFS check-in ref.
@nanoant
Copy link
Author

nanoant commented Oct 11, 2018

Okay unfortunately this needs more work 😢:

  1. It contains only files modified in given commit range, but each file also includes modification done before base ref, which is undesired behavior.
  2. Commit message also contains messages from commits before base ref.

Therefore, please do not merge it yet! But if you have an idea how make it working, let me know.

@nanoant nanoant changed the title Allow specifying custom shelveset base for shelve command [Needs work] Allow specifying custom shelveset base for shelve command Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant