Build arm64 in CI

[AArnott]

Per discussion in #10649, the work to build for arm64 has been done, but not the work to include that in official builds.

This PR adds the arm64 build to CI so that it can ship with each release.

[AArnott]

Some more observations:

• I can't tell from the appveyor log where the built binaries go, because of the 'quiet' verbosity setting. So while appveyor isn't capturing any arm64 artifact, it's difficult to understand why.
• I can't build locally because of a build break as described here.
• The MSI built seems to only build for x64. I'm not sure if a single MSI can pick up binaries for multiple architectures or if we need two build two MSIs.

[RussKie]

Some more observations:

• I can't tell from the appveyor log where the built binaries go, because of the 'quiet' verbosity setting. So while appveyor isn't capturing any arm64 artifact, it's difficult to understand why.

We can temporarily increase the verbosity, if necessary. Feel free to open a PR with the necessary change.
We use the artifacts layout similar to what's used by the .NET Arcade SDK, the layout is defined here:

gitextensions/scripts/RepoLayout.props

Lines 27 to 45 in cad0513

	<PropertyGroup>
	<RepositoryToolsDir>$([MSBuild]::NormalizeDirectory('$(RepoRoot)', '.tools'))</RepositoryToolsDir>
	<ArtifactsDir Condition="'$(ArtifactsDir)' == ''">$([MSBuild]::NormalizeDirectory('$(RepoRoot)', 'artifacts', '$(Configuration)'))</ArtifactsDir>
	<ArtifactsToolsetDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'toolset'))</ArtifactsToolsetDir>
	<ArtifactsObjDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'obj'))</ArtifactsObjDir>
	<ArtifactsBinDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'bin'))</ArtifactsBinDir>
	<ArtifactsPluginsDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'GitExtensions', '$(SolutionTargetFramework)', 'Plugins'))</ArtifactsPluginsDir>
	<ArtifactsTestsDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinDir)', 'tests'))</ArtifactsTestsDir>
	<ArtifactsLogDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'log'))</ArtifactsLogDir>
	<ArtifactsTmpDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'tmp'))</ArtifactsTmpDir>
	<ArtifactsTestResultsDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'TestResults'))</ArtifactsTestResultsDir>
	<ArtifactsPackagesDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'packages'))</ArtifactsPackagesDir>
	<ArtifactsUnitTestsDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsTestsDir)', 'UnitTests'))</ArtifactsUnitTestsDir>
	<ArtifactsIntegrationTestsDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsTestsDir)', 'IntegrationTests'))</ArtifactsIntegrationTestsDir>
	<ArtifactsPublishDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsDir)', 'publish'))</ArtifactsPublishDir>
	<AppPublishDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsPublishDir)', 'GitExtensions'))</AppPublishDir>
	</PropertyGroup>

• I can't build locally because of a build break as described here.

According to the discussion you were able to find a remedy. Is that correct?

• The MSI built seems to only build for x64. I'm not sure if a single MSI can pick up binaries for multiple architectures or if we need two build two MSIs.

The wix is very finicky, and we have very limited knowledge of it. Generally, it may be simpler to create two different installers - one for each platform.

We currently don't produce an msi for arm64 builds:

gitextensions/GitExtensions/Project.Publish.targets

Lines 288 to 348 in cad0513

	<Target Name="CreateMsi" Condition="'$(Arm64Build)' != 'true'" AfterTargets="CreatePortable">
	<PropertyGroup>
	<_AppVeyorSuffix>$(ARTIFACT_BUILD_SUFFIX)</_AppVeyorSuffix>
	<_PublishMsiVersionSuffix>-$(CurrentBuildVersion.ToString())$(_AppVeyorSuffix)</_PublishMsiVersionSuffix>
	<_PublishMsiCommitHashSuffix Condition="'$(GitCommit)' != ''">-$(GitCommit)</_PublishMsiCommitHashSuffix>
	<_PublishMsiCommitHashSuffix Condition="'$(env:APPVEYOR_REPO_COMMIT)' != ''">-$(env:APPVEYOR_REPO_COMMIT)</_PublishMsiCommitHashSuffix>
	<_PublishMsiCommitHashSuffix Condition="'$(env:APPVEYOR_PULL_REQUEST_HEAD_COMMIT)' != ''">-$(env:APPVEYOR_PULL_REQUEST_HEAD_COMMIT)</_PublishMsiCommitHashSuffix>
	<_PublishMsiFileName>GitExtensions$(_PublishMsiVersionSuffix)$(_PublishMsiCommitHashSuffix)</_PublishMsiFileName>
	<_PublishMsiPath>$([MSBuild]::NormalizePath('$(ArtifactsPublishDir)'))</_PublishMsiPath>
	</PropertyGroup>
	<!-- Determine WiX version from the referenced package -->
	<ItemGroup>
	<_WiX Include="@(PackageReference)" Condition="$([System.String]::Copy('%(Identity)')) == 'WiX'" />
	</ItemGroup>
	<Error Text="WiX package reference can't be found" Condition="'@(_WiX->Count())' != 1" />
	<PropertyGroup>
	<_WiXVersion>%(_WiX.Version)</_WiXVersion>
	</PropertyGroup>
	<!-- Work out VS installation path, so we can find MSBuild.exe -->
	<PropertyGroup>
	<VSWherePath>$([MSBuild]::NormalizePath('$(Pkgvswhere)', 'tools'))</VSWherePath>
	</PropertyGroup>
	<Exec
	Command="vswhere.exe -latest -prerelease -property installationPath -requires Microsoft.Component.MSBuild"
	WorkingDirectory="$(VSWherePath)"
	EchoOff="true"
	ConsoleToMsBuild="true"
	StandardOutputImportance="Low">
	<Output TaskParameter="ConsoleOutput" PropertyName="_VSInstallPath" />
	</Exec>
	<PropertyGroup>
	<_MSBuildCurrentPath>$([MSBuild]::NormalizePath('$(_VSInstallPath)', 'MSBuild', 'Current', 'Bin'))</_MSBuildCurrentPath>
	<_SetupArgs>/p:Configuration=$(Configuration);Platform=x86;WiXVersion=$(_WiXVersion);Version=$(CurrentBuildVersion);ArtifactsBinPath=$(ArtifactsBinDir);ArtifactsPublishPath=$(AppPublishDir);OutputPath=$(_PublishMsiPath.TrimEnd('\'));TargetName=$(_PublishMsiFileName)</_SetupArgs>
	</PropertyGroup>
	<!-- WiX isn't yet compatible with .NET. See: https://github.com/wixtoolset/issues/issues/5627
	So can't use the normal tool chain (i.e. dotnet publish or MSBuild task) and must fall back
	to manually invoke msbuild.exe.
	When WiX becomes .NET compatible we may be able to invoke the following:
	<MSBuild
	Projects="$(ProjectDir)\..\Setup\Setup.wixproj"
	Targets="Build"
	Properties="Configuration=$(Configuration);Platform=x86;WiXVersion=$(_WiXVersion);Version=$(CurrentBuildVersion);ArtifactsBinPath=$(ArtifactsBinDir);ArtifactsPublishPath=$(AppPublishDir);OutputPath=$(_PublishMsiPath.TrimEnd('\'));TargetName=$(_PublishMsiFileName)"
	StopOnFirstFailure="true"
	/>
	-->
	<Exec
	Command="msbuild.exe $(ProjectDir)\..\Setup\Setup.wixproj /v:q /t:Build $(_SetupArgs) /bl:$(ArtifactsLogDir)\setup.binlog"
	WorkingDirectory="$(_MSBuildCurrentPath)"
	EchoOff="true"
	ConsoleToMsBuild="true"
	StandardOutputImportance="High">
	</Exec>
	</Target>

The setup should be configurable, meaning it should package files from an arbitrary "publish" directory supplied as a cli argument (like this):

gitextensions/Setup/Setup.wixproj

Lines 22 to 24 in cad0513

	<PluginManagerSourceDir>$([MSBuild]::NormalizeDirectory('$(ArtifactsBinPath)', '..', 'publish'))</PluginManagerSourceDir>
	<DefineConstants>Version=$(Version);NumericVersion=$(Version);ArtifactsBinPath=$(ArtifactsBinPath);ArtifactsPublishPath=$(ArtifactsPublishPath);PluginManagerSourceDir=$(PluginManagerSourceDir)\GitExtensions.PluginManager\Output</DefineConstants>
	<DefineConstants Condition=" '$(Configuration)' == 'Debug' ">Debug;$(DefineConstants)</DefineConstants>

[AArnott]

I haven't overcome my inability to build locally yet, no. Still waiting on the VC++ team to help me understand why.

[MagicAndre1981]

WiX v4.0.3 has arm64 fixes, so try the new version:

https://wixtoolset.org/docs/releasenotes/#v4