-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to set category to FormClone/FormInit #11403
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot of duplicated code. Could you create a class that will handle most of the logic?
Oh! And you need to run the |
Thank you for the suggestions, will do! |
Look at GitHub plugin for another place to add. |
Please create a new user control that encapsulates all the necessary logic. |
This pull request has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 14 days. It will be closed if no further activity occurs. |
Apologies for delay, had other commitments, planning to finish this one soon. Thanks everyone for suggestions, all noted. |
Fixes #11312
Proposed changes
Add an option to assign a category on creating or cloning a repository via an editable combobox (disabled by default). I don't think it makes sense from UX point of view to add it also to FormOpen.
Screenshots
Before
After
Test methodology
Manual testing.
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.