-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Experimental support of dashboard details list view #9694
base: master
Are you sure you want to change the base?
Experimental support of dashboard details list view #9694
Conversation
Because I'm the kind of person that find painful to search something in a grid, I like your proposition (even if I don't use a lot the dashboard) Even if I know that it is still in development, I have some remarks (that maybe you are already aware of but it's better to be sure...):
Image illustrating this 3 points:
|
I also prefer lists. Do we need to support both views? |
In general I am supporting of an idea updating and making the dashboard more usable. But if we're changing it I'd like us to make it usable across a wide spectrum of setups. Looking at the screenshot I think that allowing this mode would be an improvement in some scenarios but not others. E.g. how does it look on a 4K monitor? Also some of our users have reported to have 250+ repos in their dashboards, what would be the experience in such (extreme) cases? I'd like to push you a little further an entertain an idea of having two listviews - one for recent items, and one for favourites. I showed a mock here: #8561 (comment). This way I think we can increase the usability without taking anything away. |
I'm happy to work on this PR to make the dashboard as useful as we can make it.
|
Below are personal thoughts and views (thank you for asking). Others may have there own views and wishes.
Yes.
Yes
I think the layout should apply to all views. This will make it easier to implement and maintain in my view.
Sizing is difficult to determine up front, as there are a number of scenarios and possibilities to address those. E.g., here's a telemetry data from 4K users in the last 90 days: I think we may need to experiment, but have some sort of semi-fluid sizing, e.g. (the numbers are arbitrary):
In the tiles view the recents listview should contain a single column, whilst the favourites listview can contain multiple columns (to make use of the available space). I've noticed that in your screenshots you have short paths, which isn't necessary what others use or prefer. So we'll need to cater for everyone. E.g. here's my dashboard (on my personal computer):
Yes
Yes
Yes, in the detailed view. Use
Yes. We use icons from http://p.yusukekamiyamane.com/, I'm sure you can find good icons for this. |
e4e5d86
to
0b3dd90
Compare
Fixes #8561
Proposed changes
Screenshots
Before
After
Test methodology
Test environment(s)
Merge strategy
I agree that the maintainer squash merge this PR (if the commit message is clear).
✒️ I contribute this code under The Developer Certificate of Origin.