Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add templ language #6798

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add templ language #6798

wants to merge 3 commits into from

Conversation

tris203
Copy link

@tris203 tris203 commented Apr 15, 2024 •
edited

  • I am adding a new language.
    • The extension of the new language is used in hundreds of repositories on GitHub.com.
    • I have included a real-world usage sample for all extensions added in this PR:
    • I have included a syntax highlighting grammar: [URL to grammar repo]
    • I have added a color
      • Hex value: #66D0DD
      • Rationale: Logo of project coloring
    • I have updated the heuristics to distinguish my language from others using the same extension.
      Not required (I don't think)

closes #6777

@tris203 tris203 requested a review from a team as a code owner April 15, 2024 15:05
@tris203 tris203 mentioned this pull request Apr 15, 2024
Closed
@lildude lildude changed the title feat: templ support Add templ language Apr 15, 2024
lildude
lildude requested changes Apr 15, 2024
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See inline comments

lib/linguist/languages.yml Outdated Show resolved Hide resolved
lib/linguist/languages.yml Show resolved Hide resolved
@tris203 tris203 requested a review from lildude April 15, 2024 18:27
@tris203
Copy link
Author

tris203 commented Apr 15, 2024

Addressed the comments. Thanks

@tris203
Copy link
Author

tris203 commented Apr 15, 2024

I had missed the README info. added now. Please can we re-run ci?

@tris203 tris203 requested a review from lildude April 15, 2024 20:12
lildude
lildude approved these changes Apr 16, 2024
View reviewed changes
Copy link
Member

@lildude lildude left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

Note: this PR will not be merged until close to when the next release is made. See here for more details.

@lildude lildude mentioned this pull request May 2, 2024
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lildude lildude lildude approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Templ Templating Lanuage
2 participants
@tris203 @lildude