Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-3fwx-pjgw-3558] Moby (Docker Engine) Insufficiently restricted permissions on data directory #4154

Conversation

neersighted
Copy link

Updates

  • Affected products
  • Source code location
  • Summary

Comments
github.com/moby/moby is not a valid Go package; github.com/docker/docker is still the canonical name.

@github
Copy link
Collaborator

github commented Mar 26, 2024

Hi there @tonistiigi and @thaJeztah! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to neersighted/advisory-improvement-4154 March 26, 2024 13:57
@CallmeMari
Copy link

Hi @neersighted, I appreciate your contribution to GitHub's Advisory Database. The listed package was found in Go's package manager. Are you proposing that both Moby and Docker be listed as affected because there was a fix commit located in Moby as well?

@neersighted
Copy link
Author

I'm not sure what you mean. github.com/docker/docker is the only affected Go package, and the Git repository redirects to https://github.com/moby/moby.

Go does not have a concept of relative imports -- all imports are absolute. This means that no matter opinions you have about codebase names, you cannot use the codebase as github.com/moby/moby as every 'relative' import will be broken.

In short; there is only github.com/docker/docker which is trivially verified by inspecting any source in the tree, or asking a maintainer (such as myself).

@neersighted
Copy link
Author

I am unable to add the Keep label, but this PR is still "fresh" and I would like to merge it.

@advisory-database advisory-database bot merged commit 4688593 into neersighted/advisory-improvement-4154 May 14, 2024
2 checks passed
@advisory-database advisory-database bot deleted the neersighted-GHSA-3fwx-pjgw-3558 branch May 14, 2024 22:00
@advisory-database
Copy link
Contributor

Hi @neersighted! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants