Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-6g7w-8wpp-frhj] Infinite loop in rustls::conn::ConnectionCommon::complete_io() with proper client input #4288

Closed

Conversation

NxPKG
Copy link

@NxPKG NxPKG commented Apr 22, 2024

Updates

  • Affected products
  • Description
  • Summary

Comments
To mitigate this vulnerability, users are advised to update to a patched version of the Rustls library. Versions 0.22 and 0.23 contain fixes for this issue and are recommended for use. Additionally, server administrators should implement appropriate rate limiting and connection timeouts to mitigate the impact of potential DoS attacks.

@github
Copy link
Collaborator

github commented Apr 22, 2024

Hi there @Taowyoo and @ctz! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to NxPKG/advisory-improvement-4288 April 22, 2024 04:34
@Taowyoo
Copy link

Taowyoo commented Apr 23, 2024

The rename of title LGTM, new name is clearer.

I only have concern about if it's fine to simplifying the python script for reproducing the original vulnerability. I would suggest keeping those binary data there or leaving a comment to tell reader to check version listed in your project repository for the full script.

@darakian
Copy link
Contributor

darakian commented May 21, 2024

I'm accepting this change but only for the updated title based on @Taowyoo 's comment. Automation is broken so, the changes have been made out of band

@darakian darakian closed this May 21, 2024
@github-actions github-actions bot deleted the NxPKG-GHSA-6g7w-8wpp-frhj branch May 21, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants