Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GHSA-98p4-xjmm-8mfh] gix-transport indirect code execution via malicious username #4316

Conversation

EliahKagan
Copy link

@EliahKagan EliahKagan commented Apr 26, 2024

Updates

  • Affected products
  • CWEs

Comments
This adds the more specific weakness CWE-88, as discussed in the pull request that fixed this vulnerability, in comments Byron/gitoxide#1342 (comment) and below. I've already made this change at the corresponding repository-level advisory GHSA-98p4-xjmm-8mfh. Because CWE-88 is a child of CWE-77, I wasn't sure if it was best to keep CWE-77 as well, but several other git-related advisories, some of which this resembles, do list both explicitly. If CWE-88 ought instead to replace CWE-77 here, then I have no objection to that.

@github
Copy link
Collaborator

github commented Apr 26, 2024

Hi there @EliahKagan and @Byron! A community member has suggested an improvement to your security advisory. If approved, this change will affect the global advisory listed at github.com/advisories. It will not affect the version listed in your project repository.

This change will be reviewed by our Security Curation Team. If you have thoughts or feedback, please share them in a comment here! If this PR has already been closed, you can start a new community contribution for this advisory

@github-actions github-actions bot changed the base branch from main to EliahKagan/advisory-improvement-4316 April 26, 2024 07:16
Copy link

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@advisory-database advisory-database bot merged commit 3480d79 into EliahKagan/advisory-improvement-4316 Apr 26, 2024
2 checks passed
@advisory-database advisory-database bot deleted the EliahKagan-GHSA-98p4-xjmm-8mfh branch April 26, 2024 16:52
@advisory-database
Copy link
Contributor

Hi @EliahKagan! Thank you so much for contributing to the GitHub Advisory Database. This database is free, open, and accessible to all, and it's people like you who make it great. Thanks for choosing to help others. We hope you send in more contributions in the future!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants