Don't use empty attribute syntax in HTML renderer #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See: github#245 Fixed a regression introduced in 0.29.0.gfm.2, where cmark-gfm would emit empty data-* attributes in HTML renderer, valid as HTML5, but invalid as XHTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, this fixes issue #245
Fixed a regression introduced in 0.29.0.gfm.2, where cmark-gfm would emit empty data-* attributes in HTML renderer, valid as HTML5, but invalid as XHTML.
I use cmark-gfm as part of my static site preprocessor and templating engine microsounds/kagami which I use for my personal website and while it's not explicitly stated as a requirement, I strive for XHTML5 compliance, a robust subset of XHTML and HTML5 as defined by W3C and WHATWG, and empty attribute syntax (attribute minimization) is invalid XHTML, preventing me from using my web browser's built in XHTML parser for strict syntax validation.