Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat status reports as non-critical #2121

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

jsoref
Copy link
Contributor

@jsoref jsoref commented Feb 8, 2024

Resolve github/codeql#15462 (comment) by converting sendStatusReport into a function that always returns void and uses core.warning instead of core.error

Split from:

Merge / deployment checklist

  • Confirm this change is backwards compatible with existing workflows.
  • Confirm the readme has been updated if necessary.
  • Confirm the changelog has been updated if necessary.

@jsoref jsoref requested a review from a team as a code owner February 8, 2024 03:09
Copy link
Contributor

@angelapwen angelapwen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again for this — our telemetry reporting should indeed be non-critical! I've just added a few comments.

I think this may warrant a CHANGELOG entry 🌞 users who may have seen this failure in the past should be happy to see the change.

src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@aeisenberg aeisenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great. I have a few copy-editing suggestions and one question about 404/403 errors.

package.json Outdated Show resolved Hide resolved
src/status-report.ts Outdated Show resolved Hide resolved
src/status-report.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
src/upload-lib.ts Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@jsoref jsoref force-pushed the status-reports-are-not-critical branch from ac030dd to 5942183 Compare February 9, 2024 21:02
aeisenberg
aeisenberg previously approved these changes Feb 9, 2024
@@ -16,6 +16,11 @@ import { parseRepositoryNwo, RepositoryNwo } from "./repository";
import * as util from "./util";
import { SarifFile, ConfigurationError, wrapError } from "./util";

const GENERIC_403_MSG =
"The repo on which this action is running has not opted-in to CodeQL code scanning.";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This message and the one below it needs some work, but as you mentioned, it is outside the scope of this PR.

@aeisenberg
Copy link
Contributor

Thanks again for your work on this.

src/status-report.ts Outdated Show resolved Hide resolved
aeisenberg
aeisenberg previously approved these changes Feb 12, 2024
Change `sendStatusReport` to `void`
@aeisenberg aeisenberg merged commit 4075abf into github:main Feb 12, 2024
295 checks passed
@aeisenberg
Copy link
Contributor

Thanks again! Nice work here.

This was referenced May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Workflows are missing permissions requests
3 participants